[WLANware] dhcpsplash bug in blocked macs

[Lorenz Schori]

Hi all

There was a bug in dhcpsplash affecting the blocked mac list in
dhcpsplash. I introduced it myself back in January in the course of a
rewrite of the firewall rules.

The Bug is still present in Freifunk 1.6.30 but is fixed in CVS now.

Lorenz


revision 1.12
date: 2008/08/27 05:52:39;  author: lschori;  state: Exp;  lines: +1 -1
Fixed typo in iptables mac-filtering rule. Thanks to Jose Monteiro for
reporting this.

*** functions.sh    2008-08-27 04:49:47.000000000 +0100
--- functions-broken.sh    2008-08-27 04:50:27.000000000 +0100
***************
*** 166,172 ****
          while read mac hostname ; do
              test -z "$mac" && continue
              splash_isknownmac "$mac" && splash_removemac "$mac"
!             $IPTABLES -t filter -I splash_blocked -m mac --mac-source
"$mac" -j DROP >/dev/null 2>&1
          done < /etc/dhcpsplash/blocked
      fi
  }
--- 166,172 ----
          while read mac hostname ; do
              test -z "$mac" && continue
              splash_isknownmac "$mac" && splash_removemac "$mac"
!             $IPTABLES -t filter -I splash_blocked-m mac --mac-source 
"$mac" -j DROP >/dev/null 2>&1
          done < /etc/dhcpsplash/blocked
      fi
  }