<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta name=Generator content="Microsoft Word 15 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:Wingdings;
panose-1:5 0 0 0 0 0 0 0 0 0;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=DE link="#0563C1" vlink="#954F72"><div class=WordSection1><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'>Hallo Christian,<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'>wenn ich das richtig sehe passiert das alles hier:<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'><a href="https://github.com/openwrt/openwrt/blob/2c60de0e3f8cbe088fe8e495697cb9e98380710d/package/base-files/files/lib/functions.sh#L256">https://github.com/openwrt/openwrt/blob/2c60de0e3f8cbe088fe8e495697cb9e98380710d/package/base-files/files/lib/functions.sh#L256</a><o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'>Dort steht am Ende ein „uci commit“ für alles. Streng genommen wäre es also nicht notwendig, das nochmal in die Dateien zu schreiben.<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'>Tatsächlich bin ich aber im Sinne der Ordnung ein Freund davon, in jeder /etc/uci-defaults Datei das zu committen, was sie tut. Würde der „uci commit“ am Schluss irgendwann aus OpenWrt wegfallen, würden wir das wahrscheinlich nicht mitkriegen und daher ist das neben der Ordnung auch ein bisschen Absicherung. Das bedeutet zwar ein bisschen mehr Schreiben auf dem Flash (da uci commit nur die Checksummen des ganzen Files prüft, um ihn zu überschreiben), aber das ist ja nur einmal beim upgrade, daher kommt es darauf meines Erachtens nicht an.<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'>Ich persönlich halte mich daher an „meine persönliche“ Regel, in die uci-defaults immer commits für das reinzuschreiben, was ich dort ändere (also uci commit system, uci commit network, etc.). Ansonsten ist das ein wildes Chaos, da vll. andere Leute andere Regeln hierfür haben.<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'>Basierend auf meinem grep sieht es so aus, als würde OpenWrt tendenziell eher kein uci commit da rein schreiben. Da die uci-default Skripte aber in der Regel zu Packages gehören, hängt es da auch wieder vom Geschmack des Package-Maintainers ab. (Das batman-adv Migrations-Skript hat z.B. eins).<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'>Mach also, was du willst </span><span style='font-size:11.0pt;font-family:Wingdings;color:#1F497D;mso-fareast-language:EN-US'>J</span><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'><o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'>Grüße<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'>Adrian<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'><o:p> </o:p></span></p><div style='border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt'><div><div style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm'><p class=MsoNormal><b><span lang=EN-US style='font-size:11.0pt;font-family:"Calibri",sans-serif'>From:</span></b><span lang=EN-US style='font-size:11.0pt;font-family:"Calibri",sans-serif'> franken-dev [mailto:franken-dev-bounces@freifunk.net] <b>On Behalf Of </b>Christian Dresel<br><b>Sent:</b> Samstag, 4. Januar 2020 17:29<br><b>To:</b> franken-dev@freifunk.net<br><b>Subject:</b> uci-defaults -> uci commit ja oder nein?<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><p><span style='font-family:"Calibri",sans-serif'>Hi</span> <o:p></o:p></p><p><span style='font-family:"Calibri",sans-serif'>braucht man in den uci-defauls ein uci commit am Ende oder wird das</span> <br><span style='font-family:"Calibri",sans-serif'>alles automatisch am Ende commitet? Wir machen für manche Sachen ein</span> <br><span style='font-family:"Calibri",sans-serif'>commit, für manche nicht:</span> <o:p></o:p></p><p><span style='font-family:"Calibri",sans-serif'>Beispiel mit commit:</span> <br><span style='font-family:"Calibri",sans-serif'>- 50-fff-boardname (bzw. jetzt 15)</span> <br><span style='font-family:"Calibri",sans-serif'>- 93-fff-nodewatcher</span> <br><span style='font-family:"Calibri",sans-serif'>- 51-fff-timeserver</span> <br><span style='font-family:"Calibri",sans-serif'>- 98-configure-fff (hier wird sogar allgemein alles commited, da es fast</span> <br><span style='font-family:"Calibri",sans-serif'>ganz am Ende ist, wird der rest wohl mitgerissen)</span> <o:p></o:p></p><p><span style='font-family:"Calibri",sans-serif'>Beispiele ohne commit:</span> <br><span style='font-family:"Calibri",sans-serif'>- 99-fff-sysupgrade</span> <br><span style='font-family:"Calibri",sans-serif'>- 51-fff-alfred</span> <br><span style='font-family:"Calibri",sans-serif'>- 55_fff-fastd</span> <o:p></o:p></p><p><span style='font-family:"Calibri",sans-serif'>Gibts da irgendeine Regel nach der man sich richten kann oder ist das</span> <br><span style='font-family:"Calibri",sans-serif'>gerade ein wildes Chaos auf das ich gestoßen bin?</span> <o:p></o:p></p><p><span style='font-family:"Calibri",sans-serif'>Gruß</span> <br><span style='font-family:"Calibri",sans-serif'>Christian</span> <o:p></o:p></p><p class=MsoNormal style='margin-bottom:12.0pt'><o:p> </o:p></p></div></div></body></html>