<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta name=Generator content="Microsoft Word 15 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=DE link=blue vlink=purple><div class=WordSection1><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'>Ja, finde ich gut.<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'>Aber dann bevorzuge ich „uci show gateway > /dev/null“<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'>Grüße<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'>Adrian<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'><o:p> </o:p></span></p><div style='border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt'><div><div style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm'><p class=MsoNormal><b><span lang=EN-US style='font-size:11.0pt;font-family:"Calibri",sans-serif'>From:</span></b><span lang=EN-US style='font-size:11.0pt;font-family:"Calibri",sans-serif'> Fabian Bläse [mailto:fabian@blaese.de] <br><b>Sent:</b> Sonntag, 8. September 2019 12:39<br><b>To:</b> mail@adrianschmutzler.de; franken-dev@freifunk.net; 'robert' <rlanghammer@web.de><br><b>Subject:</b> Re: [PATCH v2] fff-gateway: Add sanity checks<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><p><span style='font-family:"Calibri",sans-serif'>Mir ist grade folgendes untergekommen, warum die uci get oder uci show Lösung vielleicht dennoch eine gute Idee ist: Sie kann auch Syntaxfehler sinnvoll erkennen.</span><o:p></o:p></p><p><span style='font-family:"Calibri",sans-serif'>> root@doofi-router:~# configuregateway -c</span> <br><span style='font-family:"Calibri",sans-serif'>> This script might remove existing vlans, interfaces, addresses, etc.</span> <br><span style='font-family:"Calibri",sans-serif'>> Do you really want to continue? (y/n) y</span> <br><span style='font-family:"Calibri",sans-serif'>> </span><br><span style='font-family:"Calibri",sans-serif'>> uci: Parse error (EOF with unterminated ') at line 32, byte 620</span> <br><span style='font-family:"Calibri",sans-serif'>> ERROR: Gateway config does not exists.</span> <br><span style='font-family:"Calibri",sans-serif'>> </span><br><span style='font-family:"Calibri",sans-serif'>> Error when executing configure from 01-version</span> <o:p></o:p></p><p><span style='font-family:"Calibri",sans-serif'>Die Fehlermeldung sollte man dann entsprechend anpassen:</span> <br><span style='font-family:"Calibri",sans-serif'>"Gateway config could not be parsed or does not exist."</span> <o:p></o:p></p><p><span style='font-family:"Calibri",sans-serif'>Zudem ist es dann sinnvoll, das -q im passenden uci-call zu entfernen.</span> <o:p></o:p></p><p><span style='font-family:"Calibri",sans-serif'>Beides zusammen kann man eigentlich auch in einem Test abbilden, da der Versionscheck gleichzeitig auch prüft, ob die Datei existiert:</span><o:p></o:p></p><p><span style='font-family:"Calibri",sans-serif'>- Zuerst uci get auf die Version machen. uci return Wert != 0 -> does not exist or could not be parsed</span> <br><span style='font-family:"Calibri",sans-serif'>- Dann config version auswerten.</span> <o:p></o:p></p><p><span style='font-family:"Calibri",sans-serif'>Gruß</span> <br><span style='font-family:"Calibri",sans-serif'>Fabian</span> <o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p><span style='font-family:"Calibri",sans-serif'>On 20.08.19 23:04, <a href="mailto:mail@adrianschmutzler.de">mail@adrianschmutzler.de</a> wrote:</span> <br><span style='font-family:"Calibri",sans-serif'>> Also ich bin eher dagegen, da das effektiv ein undokumentiertes Feature ist.</span> <br><span style='font-family:"Calibri",sans-serif'>> </span><br><span style='font-family:"Calibri",sans-serif'>> </span> <br><span style='font-family:"Calibri",sans-serif'>> </span><br><span style='font-family:"Calibri",sans-serif'>> Ich würde entweder Fabians Lösung mit show > dev/null oder den alten [ -s ] nehmen.</span> <br><span style='font-family:"Calibri",sans-serif'>> </span><br><span style='font-family:"Calibri",sans-serif'>> </span> <br><span style='font-family:"Calibri",sans-serif'>> </span><br><span style='font-family:"Calibri",sans-serif'>> Grüße</span> <br><span style='font-family:"Calibri",sans-serif'>> </span><br><span style='font-family:"Calibri",sans-serif'>> </span> <br><span style='font-family:"Calibri",sans-serif'>> </span><br><span style='font-family:"Calibri",sans-serif'>> Adrian</span> <br><span style='font-family:"Calibri",sans-serif'>> </span><br><span style='font-family:"Calibri",sans-serif'>> </span> <br><span style='font-family:"Calibri",sans-serif'>> </span><br><span style='font-family:"Calibri",sans-serif'>> *From:*franken-dev [<a href="mailto:franken-dev-bounces@freifunk.net">mailto:franken-dev-bounces@freifunk.net</a>] *On Behalf Of *robert</span> <br><span style='font-family:"Calibri",sans-serif'>> *Sent:* Dienstag, 20. August 2019 22:59</span> <br><span style='font-family:"Calibri",sans-serif'>> *To:* <a href="mailto:franken-dev@freifunk.net">franken-dev@freifunk.net</a></span> <br><span style='font-family:"Calibri",sans-serif'>> *Subject:* Re: [PATCH v2] fff-gateway: Add sanity checks</span> <br><span style='font-family:"Calibri",sans-serif'>> </span><br><span style='font-family:"Calibri",sans-serif'>> </span> <br><span style='font-family:"Calibri",sans-serif'>> </span><br><span style='font-family:"Calibri",sans-serif'>> Hi,</span> <br><span style='font-family:"Calibri",sans-serif'>> </span><br><span style='font-family:"Calibri",sans-serif'>> ein uci get config prüft nur die Existenz der Datei. Test:</span> <br><span style='font-family:"Calibri",sans-serif'>> </span><br><span style='font-family:"Calibri",sans-serif'>> root@c2600:/etc/config# > robert</span> <br><span style='font-family:"Calibri",sans-serif'>> root@c2600:/etc/config# uci get robert</span> <br><span style='font-family:"Calibri",sans-serif'>> root@c2600:/etc/config# echo $?</span> <br><span style='font-family:"Calibri",sans-serif'>> 0</span> <br><span style='font-family:"Calibri",sans-serif'>> root@c2600:/etc/config# rm robert</span> <br><span style='font-family:"Calibri",sans-serif'>> root@c2600:/etc/config# uci get robert</span> <br><span style='font-family:"Calibri",sans-serif'>> uci: Entry not found</span> <br><span style='font-family:"Calibri",sans-serif'>> root@c2600:/etc/config# echo $?</span> <br><span style='font-family:"Calibri",sans-serif'>> 1</span> <br><span style='font-family:"Calibri",sans-serif'>> </span><br><span style='font-family:"Calibri",sans-serif'>> Also nicht mal den Inhalt. Man könnte also auch ein [ -f Datei ] nehmen.</span> <br><span style='font-family:"Calibri",sans-serif'>> </span><br><span style='font-family:"Calibri",sans-serif'>> Da es keinen Unterschied macht, würde ich es so lassen.</span> <br><span style='font-family:"Calibri",sans-serif'>> </span><br><span style='font-family:"Calibri",sans-serif'>> Grüße</span> <br><span style='font-family:"Calibri",sans-serif'>> Robert</span> <br><span style='font-family:"Calibri",sans-serif'>> </span><br><span style='font-family:"Calibri",sans-serif'>> Am 20.08.19 um 17:06 schrieb Fabian Bläse:</span> <br><span style='font-family:"Calibri",sans-serif'>>> Hey Adrian,</span> <br><span style='font-family:"Calibri",sans-serif'>>></span> <br><span style='font-family:"Calibri",sans-serif'>>> dann hab ich die Frage falsch verstanden oder unaufmerksam gelesen, sorry.</span> <br><span style='font-family:"Calibri",sans-serif'>>></span> <br><span style='font-family:"Calibri",sans-serif'>>> Du hast recht, die uci help sagt, dass eine "section" mit angegeben werden soll.</span> <br><span style='font-family:"Calibri",sans-serif'>>> In so fern ist es wohl fraglich, ob wir uns auf das Verhalten verlassen können.</span> <br><span style='font-family:"Calibri",sans-serif'>>></span> <br><span style='font-family:"Calibri",sans-serif'>>> Man könnte auch "uci show gateway >/dev/null" verwenden..</span> <br><span style='font-family:"Calibri",sans-serif'>>></span> <br><span style='font-family:"Calibri",sans-serif'>>> Gruß</span> <br><span style='font-family:"Calibri",sans-serif'>>> Fabian</span> <br><span style='font-family:"Calibri",sans-serif'>>></span> <br><span style='font-family:"Calibri",sans-serif'>> </span><br><span style='font-family:"Calibri",sans-serif'>> </span> <br><span style='font-family:"Calibri",sans-serif'>> </span><o:p></o:p></p><p class=MsoNormal style='margin-bottom:12.0pt'><o:p> </o:p></p></div></div></body></html>