[PATCH v2] fff-gateway: Add sanity checks

robert rlanghammer at web.de
Do Aug 15 23:26:48 CEST 2019


Hi Fabian,

Reviewed-by: Robert Langhammer <rlanghammer at web.de>

Am 15.08.19 um 13:52 schrieb Fabian Bläse:
> This adds two checks:
> - Does gateway config exist?
> - Does gateway config version match?
>
> Signed-off-by: Fabian Bläse <fabian at blaese.de>
> ---
> Changes in v2:
> - Add exit to gateway config check
> - Fix incorrectly escaped apostrophe
> ---
>  .../files/etc/gateway.d/01-version            | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)
>  create mode 100644 src/packages/fff/fff-gateway/files/etc/gateway.d/01-version
>
> diff --git a/src/packages/fff/fff-gateway/files/etc/gateway.d/01-version b/src/packages/fff/fff-gateway/files/etc/gateway.d/01-version
> new file mode 100644
> index 0000000..1f0b1b1
> --- /dev/null
> +++ b/src/packages/fff/fff-gateway/files/etc/gateway.d/01-version
> @@ -0,0 +1,19 @@
> +configure() {
> +	local expected_version=1
> +	local config_version=$(uci -q get gateway.version.config_version)
> +
> +	# check if gateway config exists
> +	if ! uci -q get gateway; then
> +		echo "ERROR: Gateway config does not exists."
> +
> +		exit 1
> +	fi
> +
> +	# check version of configuration
> +	if [ "$config_version" != "$expected_version" ]; then
> +		echo "ERROR: Invalid config version. Expected '$expected_version', got '$config_version'."
> +		echo "Please check what has been changed and adjust your config appropriately."
> +
> +		exit 1
> +	fi
> +}


Mehr Informationen über die Mailingliste franken-dev