[PATCH] Remove batman option no_rebroadcast

Robert Langhammer rlanghammer at web.de
So Nov 11 13:40:49 CET 2018


Auch von mir Zustimmung!
Robert 

Am 11. November 2018 13:07:20 MEZ schrieb mail at adrianschmutzler.de:
>Hallo,
>
> 
>
>ich würde die Commit-Description folgendermaßen ergänzen, damit man das
>beim nächsten Mal nicht wieder ewig rekonstruieren muss.
>
> 
>
>>
> 
>
>The no_rebroadcast option was used as part of gluon’s batman-adv-legacy
>implementation, after open-mesh decided to not include it into
>batman-adv v14:
>
> 
>
>https://patchwork.open-mesh.org/patch/3434/
>
> 
>
>Our firmware has included (and enabled) it since December 2013.
>
> 
>
>With the upgrade to batman-adv v15 (pulled from openwrt-routing then)
>in October 2017, the custom patch was no longer included.
>
>It looks like open-mesh provides an equivalent built-in solution now:
>
> 
>
>https://git.open-mesh.org/batman-adv.git/commit/a00797d8fa8fd1471e8be1ac23d506f76d866aaa
>
> 
>
>Thus, the option can be removed.
>
> 
>
>>
> 
>
>Bitte um Zustimmung.
>
> 
>
>Grüße
>
> 
>
>Adrian
>
> 
>
> 
>
> 
>
> 
>
>From: franken-dev [mailto:franken-dev-bounces at freifunk.net] On Behalf
>Of Christian Dresel
>Sent: Sonntag, 11. November 2018 12:40
>To: Robert Langhammer <rlanghammer at web.de>; franken-dev at freifunk.net
>Subject: Re: [PATCH] Remove batman option no_rebroadcast
>
> 
>
>hi 
>
>wie hier gewünscht: 
>
>http://lists.freifunk.net/pipermail/franken-dev-freifunk.net/2018-November/014739.html
>
>
>mit dieser Erklärung: 
>
>http://lists.freifunk.net/pipermail/franken-dev-freifunk.net/2018-November/014738.html
>
>
>dann hier das 
>
>Reviewed-by: Christian Dresel <fff at chrisi01.de <mailto:fff at chrisi01.de>
>> 
>
>mfg 
>
>Christian 
>
>Am 28.07.18 um 23:58 schrieb Robert Langhammer: 
>> This sysfs option no longer exists. 
>> 
>> Signed-off-by: Robert Langhammer <rlanghammer at web.de
><mailto:rlanghammer at web.de> > 
>> --- 
>>  src/packages/fff/fff-fastd/files/etc/uci-defaults/55_fff-fastd      
>    | 1 - 
>>  .../fff/fff-tunneldigger/files/etc/tunneldigger/tunneldigger.hook   
>    | 1 - 
>>  2 files changed, 2 deletions(-) 
>> 
>> diff --git
>a/src/packages/fff/fff-fastd/files/etc/uci-defaults/55_fff-fastd
>b/src/packages/fff/fff-fastd/files/etc/uci-defaults/55_fff-fastd
>
>> index 72970bd..d53eb43 100644 
>> --- a/src/packages/fff/fff-fastd/files/etc/uci-defaults/55_fff-fastd 
>> +++ b/src/packages/fff/fff-fastd/files/etc/uci-defaults/55_fff-fastd 
>> @@ -22,6 +22,5 @@ EOF 
>>  ln -s /tmp/fastd_fff_peers /etc/fastd/fff/peers 
>>  echo "#!/bin/sh" > /etc/fastd/fff/up.sh 
>>  echo "ip link set up dev fffVPN" >> /etc/fastd/fff/up.sh 
>> -echo "echo enable >
>/sys/devices/virtual/net/fffVPN/batman_adv/no_rebroadcast" >>
>/etc/fastd/fff/up.sh 
>>  echo "batctl if add fffVPN" >> /etc/fastd/fff/up.sh 
>>  chmod +x /etc/fastd/fff/up.sh 
>> diff --git
>a/src/packages/fff/fff-tunneldigger/files/etc/tunneldigger/tunneldigger.hook
>b/src/packages/fff/fff-tunneldigger/files/etc/tunneldigger/tunneldigger.hook
>
>> index c4fea62..a96b42c 100755 
>> ---
>a/src/packages/fff/fff-tunneldigger/files/etc/tunneldigger/tunneldigger.hook
>
>> +++
>b/src/packages/fff/fff-tunneldigger/files/etc/tunneldigger/tunneldigger.hook
>
>> @@ -6,5 +6,4 @@ INTERFACE=$2 
>>  if [ "$HOOK" = session.up ]; then 
>>         ip l s dev $INTERFACE up 
>>         batctl if add $INTERFACE 
>> -       echo "enabled" >
>/sys/devices/virtual/net/$INTERFACE/batman_adv/no_rebroadcast 
>>  fi 
>> 
>
> 


Mehr Informationen über die Mailingliste franken-dev