[PATCH v3 2/2] fff-wireless: fix shellcheck errors
Tim Niemeyer
tim at tn-x.org
So Sep 17 16:45:48 CEST 2017
Hi
Am Sonntag, den 17.09.2017, 16:28 +0200 schrieb
mail at adrianschmutzler.de:
> Reviewed-by: Adrian Schmutzler <freifunk at adrianschmutzler.de>
> Tested-by: Adrian Schmutzler <freifunk at adrianschmutzler.de>
Danke!
Und applied.
Tim
>
> > -----Original Message-----
> > From: franken-dev [mailto:franken-dev-bounces at freifunk.net] On
> > Behalf
> > Of Tim Niemeyer
> > Sent: Samstag, 19. August 2017 14:35
> > To: franken-dev at freifunk.net
> > Subject: [PATCH v3 2/2] fff-wireless: fix shellcheck errors
> >
> > In src/packages/fff/fff-wireless/files/lib/functions/fff/wireless
> > line 26:
> > local radio="radio$(echo $phy | tr -d -C [0-9])"
> > ^-- SC2086: Double quote to
> > prevent
>
> globbing and word
> > splitting.
> > ^-- SC2060: Quote
>
> parameters to tr to prevent glob
> > expansion.
> >
> > Signed-off-by: Tim Niemeyer <tim at tn-x.org>
> > ---
> >
> > Changes in v3:
> > - New patch
> >
> > src/packages/fff/fff-wireless/files/lib/functions/fff/wireless | 2
> > +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
>
> a/src/packages/fff/fff-wireless/files/lib/functions/fff/wireless
> > b/src/packages/fff/fff-wireless/files/lib/functions/fff/wireless
> > index a083c13..12dce84 100644
> > --- a/src/packages/fff/fff-
> > wireless/files/lib/functions/fff/wireless
> > +++ b/src/packages/fff/fff-
> > wireless/files/lib/functions/fff/wireless
> > @@ -23,7 +23,7 @@ wifiAddPhy() {
> >
> > local phy=$1
> > local channel=$2
> > - local radio="radio$(echo $phy | tr -d -C [0-9])"
> > + local radio="radio$(echo "$phy" | tr -d -C "0-9")"
> > local hwmode="11g"
> > if [ "$channel" -gt "14" ]; then
> > hwmode="11a"
> > --
> > 2.1.4
> >
> > --
> > franken-dev mailing list
> > franken-dev at freifunk.net
> > http://lists.freifunk.net/mailman/listinfo/franken-dev-freifunk.net
>
>
-------------- nächster Teil --------------
Ein Dateianhang mit Binärdaten wurde abgetrennt...
Dateiname : signature.asc
Dateityp : application/pgp-signature
Dateigröße : 488 bytes
Beschreibung: This is a digitally signed message part
URL : <http://lists.freifunk.net/pipermail/franken-dev-freifunk.net/attachments/20170917/e093dc42/attachment.sig>
Mehr Informationen über die Mailingliste franken-dev