[PATCH] nodewatcher: fix parsing error

Tim Niemeyer tim at tn-x.org
So Jul 9 12:40:49 CEST 2017


Hi

Du meinst sicher den shellcheck parsing error?:
In nodewatcher line 107:
    if [ pidof fastd >/dev/null ] || [ grep -q '1' /sys/class/net/l2tp*/carrier ] ; then
    ^-- SC1009: The mentioned parser error was in this if expression.
       ^-- SC1073: Couldn't parse this test expression.
               ^-- SC1072: Unexpected "f". Fix any mentioned problems and try again.

Reviewed-by: Tim Niemeyer <tim at tn-x.org>

Tim

Am Dienstag, den 04.07.2017, 00:36 +0200 schrieb Tobias Klaus:
> ---
>  src/packages/fff/fff-nodewatcher/files/usr/sbin/nodewatcher | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/packages/fff/fff-nodewatcher/files/usr/sbin/nodewatcher b/src/packages/fff/fff-nodewatcher/files/usr/sbin/nodewatcher
> index 6e0e538..f9d6e65 100755
> --- a/src/packages/fff/fff-nodewatcher/files/usr/sbin/nodewatcher
> +++ b/src/packages/fff/fff-nodewatcher/files/usr/sbin/nodewatcher
> @@ -104,7 +104,7 @@ crawl() {
>      fi
>  
>      #Checks whether either fastd or L2TP is connected
> -    if [ pidof fastd >/dev/null ] || [ grep -q '1' /sys/class/net/l2tp*/carrier ] ; then
> +    if pidof fastd >/dev/null || grep -q '1' /sys/class/net/l2tp*/carrier 2> /dev/null ; then
>          vpn_active="<vpn_active>1</vpn_active>"
>      else
>          vpn_active="<vpn_active>0</vpn_active>"
> -- 
> 2.13.2
> 

-------------- nächster Teil --------------
Ein Dateianhang mit Binärdaten wurde abgetrennt...
Dateiname   : signature.asc
Dateityp    : application/pgp-signature
Dateigröße  : 473 bytes
Beschreibung: This is a digitally signed message part
URL         : <http://lists.freifunk.net/pipermail/franken-dev-freifunk.net/attachments/20170709/5b10e1c7/attachment.sig>


Mehr Informationen über die Mailingliste franken-dev