[PATCH v2 00/19] buildscript Optimierung und Bugfixes - Version 2

Tim Niemeyer tim.niemeyer at mastersword.de
Di Jul 21 08:05:24 CEST 2015


Hi Steffen

Vielen Dank für deine viele Arbeit.

Die Patches sind nun alle gereviewed und applied.

Tim

Am Freitag, den 17.07.2015, 18:46 +0200 schrieb Steffen Pankratz:
> Hi
> 
> ich habe nach Eurem Feedback die Patch Serie ueberarbeitet:
> 
> - fixed Escape Zeichen in Patch 08
> - squashed PATCH 09 und 10 + notwendige Anpassungen in nodewatcher.sh
> - Patch 13, jetzt Patch 12, Loesung ohne eval, alte Implementierung refactored
> - Patch 17, jetzt Patch 16, Loesung ohne eval, alte Implementierung refactored
> 
> 
> Gruss
> -Steffen
> 
> Steffen Pankratz (19):
>   - removed subversion handling, not needed anymore
>   - optimized sysupgrade_no_config_save.patch patch call
>   - removed unnecessary check
>   - fixed log message in 'checkout_git' function
>   - fixed git cloning after $DIRECTORY had to be deleted
>   - optimized grep call
>   - use proper POSIX-conforming arithmetic expansion
>   - quoted log messages properly
>   - removed FIRMWARE_REVISION as it has the same information as
>     RELEASE_DATE and renamed RELEASE_DATE do better match its actual
>     purpose
>   - fixed wrong quoting
>   - fixed '$' on regular variables in arithmetic contexts has no purpose
>   - corrected FEEDVAR array handling
>   - better to use bash's build-in glob functionality instead of looping
>     over the returned find output
>   - optimization: one redirect is enough
>   - added warning about batman-adv COMPAT_VERSION
>   - corrected PACKAGESVAR array handling
>   - omit the output, we are just interested in the result
>   - added double quotes to prevent globbing and/or word splitting
>   - fixed tabs vs. spaces mix-up by using only spaces
> 
>  bsp/default/root_file_system/etc/nodewatcher.sh |   7 +-
>  buildscript                                     | 666 ++++++++++++------------
>  2 files changed, 322 insertions(+), 351 deletions(-)
> 
> -- 
> 2.4.5
> 





Mehr Informationen über die Mailingliste franken-dev