<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><meta name=Generator content="Microsoft Word 15 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0cm;
mso-margin-bottom-alt:auto;
margin-left:0cm;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
span.EmailStyle18
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle19
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 2.0cm 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style></head><body lang=DE link=blue vlink=purple><div class=WordSection1><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'>Hallo,<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'>dieser Patch liegt ja auch noch rum.<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'>Reviews hat er ja genug, ich würde folgende Zeilen entfernen und ihn ansonsten applien, wie er ist:<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'><o:p> </o:p></span></p><p class=MsoNormal><span lang=EN-US style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'>+PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.bz2<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'>+PKG_SOURCE_SUBDIR:=$(PKG_NAME)-$(PKG_VERSION)<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'><o:p> </o:p></span></p><p class=MsoNormal><span lang=EN-US style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'>Bitte kurz ACK hierfür.<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'>Die Description würde ich dann ggf. auch nochmal separat reinpatchen.<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'>Grüße<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'>Adrian<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D;mso-fareast-language:EN-US'><o:p> </o:p></span></p><div style='border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt'><div><div style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm'><p class=MsoNormal><b><span lang=EN-US style='font-size:11.0pt;font-family:"Calibri",sans-serif'>From:</span></b><span lang=EN-US style='font-size:11.0pt;font-family:"Calibri",sans-serif'> Fabian Bläse [mailto:fabian@blaese.de] <br><b>Sent:</b> Donnerstag, 27. Dezember 2018 00:13<br><b>To:</b> mail@adrianschmutzler.de; franken-dev@freifunk.net; 'Tim Niemeyer' <tim@tn-x.org><br><b>Subject:</b> Re: [PATCH v3 1/2] packages/alfred-json: added package<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><p><span style='font-family:"Calibri",sans-serif'>Hallo,</span> <o:p></o:p></p><p><span style='font-family:"Calibri",sans-serif'>@Tim: Möchtest du dieses Paket weiter pflegen (siehe Anmerkungen von Adrian und Kommentare unten) oder soll ich das übernehmen?</span><o:p></o:p></p><p><span style='font-family:"Calibri",sans-serif'>On 12.08.18 18:42, <a href="mailto:mail@adrianschmutzler.de">mail@adrianschmutzler.de</a> wrote:</span> <br><span style='font-family:"Calibri",sans-serif'>> Hallo,</span> <br><span style='font-family:"Calibri",sans-serif'>> </span><br><span style='font-family:"Calibri",sans-serif'>> Reviewed-by: Adrian Schmutzler <<a href="mailto:freifunk@adrianschmutzler.de">freifunk@adrianschmutzler.de</a>></span> <br><span style='font-family:"Calibri",sans-serif'>> </span><br><span style='font-family:"Calibri",sans-serif'>> Bitte Kommentare unten beachten und ggf. noch anpassen.</span> <br><span style='font-family:"Calibri",sans-serif'>> </span><br><span style='font-family:"Calibri",sans-serif'>> [..]</span> <br><span style='font-family:"Calibri",sans-serif'>></span> <br><span style='font-family:"Calibri",sans-serif'>>> +PKG_SOURCE_VERSION:=e4cacfc791092389f63c36a435d3f1d069f8a13e</span> <br><span style='font-family:"Calibri",sans-serif'>>> +PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.bz2</span> <br><span style='font-family:"Calibri",sans-serif'>> </span><br><span style='font-family:"Calibri",sans-serif'>> Brauchen wir das, wenn wir eine git source haben? Ich glaube, das kann weg... (Wenn ja, dann nicht nur hier...)</span> <br><span style='font-family:"Calibri",sans-serif'>Richtig, das brauchts eigentlich nicht.</span> <o:p></o:p></p><p><span style='font-family:"Calibri",sans-serif'>>> +PKG_SOURCE_SUBDIR:=$(PKG_NAME)-$(PKG_VERSION)</span> <br><span style='font-family:"Calibri",sans-serif'>Könnte man eigentlich auch weglassen, ist default.</span> <o:p></o:p></p><p><span style='font-family:"Calibri",sans-serif'>>> +PKG_SOURCE_URL:=<a href="https://github.com/FreifunkFranken/alfred-json.git">https://github.com/FreifunkFranken/alfred-json.git</a></span> <br><span style='font-family:"Calibri",sans-serif'>>> +</span> <br><span style='font-family:"Calibri",sans-serif'>>> +include $(INCLUDE_DIR)/package.mk</span> <br><span style='font-family:"Calibri",sans-serif'>>> +include $(INCLUDE_DIR)/cmake.mk</span> <br><span style='font-family:"Calibri",sans-serif'>>> +</span> <br><span style='font-family:"Calibri",sans-serif'>>> +define Package/alfred-json</span> <br><span style='font-family:"Calibri",sans-serif'>>> + SECTION:=utils</span> <br><span style='font-family:"Calibri",sans-serif'>>> + CATEGORY:=Utilities</span> <br><span style='font-family:"Calibri",sans-serif'>>> + TITLE:= A.L.F.R.E.D - JSON Client</span> <br><span style='font-family:"Calibri",sans-serif'>>> + URL:=<a href="https://github.com/FreifunkFranken/alfred-json">https://github.com/FreifunkFranken/alfred-json</a></span> <br><span style='font-family:"Calibri",sans-serif'>> </span><br><span style='font-family:"Calibri",sans-serif'>> Das ist scheinbar nur ein Info-Link. Insofern ist das so i.O. und mein Kommentar mit der Variable erübrigt sich.</span> <br><span style='font-family:"Calibri",sans-serif'>>> + DEPENDS:=+jansson +zlib</span> <br><span style='font-family:"Calibri",sans-serif'>>> +endef</span> <br><span style='font-family:"Calibri",sans-serif'>> </span><br><span style='font-family:"Calibri",sans-serif'>> Hier fehlt der description Block, wäre schon schön, ggf. Copy/Paste vom git repo.</span> <br><span style='font-family:"Calibri",sans-serif'>Könnte man noch einbauen.</span> <o:p></o:p></p><p><span style='font-family:"Calibri",sans-serif'>>> +</span> <br><span style='font-family:"Calibri",sans-serif'>>> +define Package/alfred-json/install</span> <br><span style='font-family:"Calibri",sans-serif'>>> + $(INSTALL_DIR) $(1)/bin/</span> <br><span style='font-family:"Calibri",sans-serif'>> </span><br><span style='font-family:"Calibri",sans-serif'>> Warum liegt das jetzt ausgerechnet im /bin ? (Ich glaube, dass muss mir mal jemand außerhalb der Diskussion dieses Patches erklären.)</span><o:p></o:p></p><p><span style='font-family:"Calibri",sans-serif'>Dass es sowohl /(s)bin, als auch /usr/(s)bin gibt, ist eine UNIX Eigenheit (wie so oft) aus historischen Gründen.</span> <br><span style='font-family:"Calibri",sans-serif'>Die Besonderheit von /usr ist, dass es erst später eingehängt werden kann. (z.B. über NFS, oder einfach auf einer eigenen Partition/Platte)</span><o:p></o:p></p><p><span style='font-family:"Calibri",sans-serif'>Einige Software braucht man aber zwingend, bevor man mounten kann. (z.B. "mount")</span> <br><span style='font-family:"Calibri",sans-serif'>Wo etwas jetzt tatsächlich reingehört, darüber kann man vermutlich streiten. Wenn du mich fragst, müsste das hier eher nach /usr/bin...</span><o:p></o:p></p><p><span style='font-family:"Calibri",sans-serif'>> </span><br><span style='font-family:"Calibri",sans-serif'>>> + $(CP) $(PKG_INSTALL_DIR)/usr/bin/alfred-json $(1)/bin/ endef</span> <br><span style='font-family:"Calibri",sans-serif'>> </span><br><span style='font-family:"Calibri",sans-serif'>> Keine Ahnung, warum der source-Pfad so heißen muss. Vielleicht kann mich jemand erleuchten. Da ich aber weiß, dass es funktioniert, ignoriere ich das mal für den Review.</span><o:p></o:p></p><p><span style='font-family:"Calibri",sans-serif'>make install packt alfred-json nach /usr/bin/alfred-json, $(PKG_INSTALL_DIR) verweist auf das Prefix des Install-Dirs. Daher muss das Binary von dort kopiert werden.</span><o:p></o:p></p><p><span style='font-family:"Calibri",sans-serif'>Fabian</span> <o:p></o:p></p><p class=MsoNormal style='margin-bottom:12.0pt'><br><br><br><br><br><o:p></o:p></p></div></div></body></html>