<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">Hallo,<div class=""><br class=""></div><div class="">kleine verbesserung (hoffe ich)… um negative Nummern zu vermeiden habe ich den %d in ein %u umgedreht und um etwas sauber zu sein auch ein fclose() gemacht:</div><div class=""><br class=""></div><div class=""><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">--- timsrandom.c.orig<span class="Apple-tab-span" style="white-space:pre"> </span>2017-07-02 19:04:10.000000000 +0200</span></div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">+++ timsrandom.c<span class="Apple-tab-span" style="white-space:pre"> </span>2017-07-02 19:04:39.000000000 +0200</span></div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">@@ -40,7 +40,9 @@</span></div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""> return -1;</span></div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""> }</span></div><p style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo; min-height: 13px;" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""> </span><br class="webkit-block-placeholder"></p><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">- printf("%d\n", (r % (diff +1 )) + from);</span></div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">+<span class="Apple-tab-span" style="white-space:pre"> </span>fclose(f);</span></div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">+</span></div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">+ printf("%u\n", (r % (diff +1 )) + from);</span></div><p style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo; min-height: 13px;" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""> </span><br class="webkit-block-placeholder"></p><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""> return 0;</span></div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""> }</span></div><div class=""><span style="font-variant-ligatures: no-common-ligatures" class=""><br class=""></span></div><div class=""><span style="font-variant-ligatures: no-common-ligatures" class=""><br class=""></span></div><div class=""><span style="font-variant-ligatures: no-common-ligatures" class="">so etwas in der richtung. Denn wenn man diese nummern gibt wird es negativ:</span></div><div class=""><span style="font-variant-ligatures: no-common-ligatures" class=""><br class=""></span></div><div class=""><span style="font-variant-ligatures: no-common-ligatures" class=""><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">spica:Documents pjp$ ./timsrandom 2147483648 2147483649</span></div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">-2147483648</span></div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""><br class=""></div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class="">mit dem patch sieht es so aus:</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""><br class=""></div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""><div style="margin: 0px; line-height: normal;" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">spica:Documents pjp$ cc -g -o timsrandom timsrandom.c</span></div><div style="margin: 0px; line-height: normal;" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">spica:Documents pjp$ ./timsrandom 2147483648 2147483649</span></div><div style="margin: 0px; line-height: normal;" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">2147483649</span></div></div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""><br class=""></span></div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">entschuldige bitte die etwas schlampigkeit von mir ich bin nicht in meiner komfortzone da ich auf dem wochenende macbook bin.</span></div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""><br class=""></span></div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""><span style="font-variant-ligatures: no-common-ligatures" class="">Grüße,</span></div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""><span style="font-variant-ligatures: no-common-ligatures" class=""><br class=""></span></div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class="">-peter</div><div style="margin: 0px; font-size: 11px; line-height: normal; font-family: Menlo;" class=""><br class=""></div></span></div><div><blockquote type="cite" class=""><div class="">Am 02.07.2017 um 17:40 schrieb Tim Niemeyer <<a href="mailto:tim@tn-x.org" class="">tim@tn-x.org</a>>:</div><br class="Apple-interchange-newline"><div class=""><div class="">Fixes: #51<br class=""><br class="">Signed-off-by: Tim Niemeyer <<a href="mailto:tim@tn-x.org" class="">tim@tn-x.org</a>><br class="">---<br class=""><br class=""> src/packages/fff/fff-random/Makefile | 27 ++++++------<br class=""> src/packages/fff/fff-random/files/usr/bin/random | 16 --------<br class=""> src/packages/fff/fff-random/src/Makefile | 4 ++<br class=""> src/packages/fff/fff-random/src/random.c | 52 ++++++++++++++++++++++++<br class=""> 4 files changed, 70 insertions(+), 29 deletions(-)<br class=""> delete mode 100755 src/packages/fff/fff-random/files/usr/bin/random<br class=""> create mode 100644 src/packages/fff/fff-random/src/Makefile<br class=""> create mode 100644 src/packages/fff/fff-random/src/random.c<br class=""><br class="">diff --git a/src/packages/fff/fff-random/Makefile b/src/packages/fff/fff-random/Makefile<br class="">index 95e5786..066adc3 100644<br class="">--- a/src/packages/fff/fff-random/Makefile<br class="">+++ b/src/packages/fff/fff-random/Makefile<br class="">@@ -1,40 +1,41 @@<br class=""> include $(TOPDIR)/rules.mk<br class=""><br class=""> PKG_NAME:=fff-random<br class="">-PKG_VERSION:=0.0.1<br class="">+PKG_VERSION:=2<br class=""> PKG_RELEASE:=1<br class=""><br class="">-PKG_BUILD_DIR:=$(BUILD_DIR)/fff-random<br class="">+PKG_BUILD_DIR:=$(BUILD_DIR)/$(PKG_NAME)<br class=""><br class=""> include $(INCLUDE_DIR)/package.mk<br class=""><br class=""> define Package/fff-random<br class="">- SECTION:=base<br class="">- CATEGORY:=Freifunk<br class="">- TITLE:=Freifunk-Franken Random<br class="">- URL:=<a href="http://www.freifunk-franken.de" class="">http://www.freifunk-franken.de</a><br class="">- DEPENDS:=+@BUSYBOX_CONFIG_ASH<br class="">+<span class="Apple-tab-span" style="white-space:pre"> </span>SECTION:=base<br class="">+<span class="Apple-tab-span" style="white-space:pre"> </span>CATEGORY:=Freifunk<br class="">+<span class="Apple-tab-span" style="white-space:pre"> </span>TITLE:=Freifunk-Franken Random<br class="">+<span class="Apple-tab-span" style="white-space:pre"> </span>URL:=<a href="http://www.freifunk-franken.de" class="">http://www.freifunk-franken.de</a><br class=""> endef<br class=""><br class=""> define Package/fff-random/description<br class="">- This is the Freifunk Franken Firmware Random package<br class="">- This packages provides a random function.<br class="">+<span class="Apple-tab-span" style="white-space:pre"> </span>This is the Freifunk Franken Firmware Random package<br class="">+<span class="Apple-tab-span" style="white-space:pre"> </span>This packages provides a random function.<br class=""> endef<br class=""><br class=""> define Build/Prepare<br class="">- echo "all: " > $(PKG_BUILD_DIR)/Makefile<br class="">+<span class="Apple-tab-span" style="white-space:pre"> </span>mkdir -p $(PKG_BUILD_DIR)<br class="">+<span class="Apple-tab-span" style="white-space:pre"> </span>$(CP) ./src/* $(PKG_BUILD_DIR)/<br class=""> endef<br class=""><br class=""> define Build/Configure<br class="">- # nothing<br class="">+<span class="Apple-tab-span" style="white-space:pre"> </span># nothing<br class=""> endef<br class=""><br class=""> define Build/Compile<br class="">- # nothing<br class="">+<span class="Apple-tab-span" style="white-space:pre"> </span>CFLAGS="$(TARGET_CFLAGS)" CPPFLAGS="$(TARGET_CPPFLAGS)" $(MAKE) -C $(PKG_BUILD_DIR) $(TARGET_CONFIGURE_OPTS)<br class=""> endef<br class=""><br class=""> define Package/fff-random/install<br class="">- $(CP) ./files/* $(1)/<br class="">+<span class="Apple-tab-span" style="white-space:pre"> </span>$(INSTALL_DIR) $(1)/usr/bin<br class="">+<span class="Apple-tab-span" style="white-space:pre"> </span>$(INSTALL_BIN) $(PKG_BUILD_DIR)/random $(1)/usr/bin/<br class=""> endef<br class=""><br class=""> $(eval $(call BuildPackage,fff-random))<br class="">diff --git a/src/packages/fff/fff-random/files/usr/bin/random b/src/packages/fff/fff-random/files/usr/bin/random<br class="">deleted file mode 100755<br class="">index 8f11470..0000000<br class="">--- a/src/packages/fff/fff-random/files/usr/bin/random<br class="">+++ /dev/null<br class="">@@ -1,16 +0,0 @@<br class="">-#!/bin/sh<br class="">-# Freifunk Franken Random Number Script<br class="">-# Tim Niemeyer<br class="">-# 29.11.2015<br class="">-# License GPLv2<br class="">-<br class="">-FROM=${1:-0}<br class="">-UNTIL=${2:-100}<br class="">-<br class="">-diff=$(( UNTIL - FROM ))<br class="">-numbers=$(( $(echo $diff | wc -c) -1 ))<br class="">-<br class="">-rand=$(</dev/urandom tr -dc 0-9 | head -c $numbers | sed -e 's/^0*//g')<br class="">-<br class="">-echo $(( (rand % diff) + FROM ))<br class="">-<br class="">diff --git a/src/packages/fff/fff-random/src/Makefile b/src/packages/fff/fff-random/src/Makefile<br class="">new file mode 100644<br class="">index 0000000..ab181d5<br class="">--- /dev/null<br class="">+++ b/src/packages/fff/fff-random/src/Makefile<br class="">@@ -0,0 +1,4 @@<br class="">+all: random<br class="">+<br class="">+random: random.c<br class="">+<span class="Apple-tab-span" style="white-space:pre"> </span>$(CC) $(CPPFLAGS) $(CFLAGS) $(LDFLAGS) -Wall -o $@ $^ $(LDLIBS)<br class="">diff --git a/src/packages/fff/fff-random/src/random.c b/src/packages/fff/fff-random/src/random.c<br class="">new file mode 100644<br class="">index 0000000..85dc57d<br class="">--- /dev/null<br class="">+++ b/src/packages/fff/fff-random/src/random.c<br class="">@@ -0,0 +1,52 @@<br class="">+/*<br class="">+ * Simple random tool, used to get a random value<br class="">+ * 2017-07-02<br class="">+ * Tim Niemeyer<br class="">+ * GPLv2<br class="">+ */<br class="">+#include <stdio.h><br class="">+#include <stdlib.h><br class="">+<br class="">+int main(int argc, char **argv)<br class="">+{<br class="">+ int from = 0;<br class="">+ int to = 100;<br class="">+ int diff = 1;<br class="">+ FILE *f = 0;<br class="">+ unsigned int r = 0;<br class="">+<br class="">+ if (argc != 1 && argc != 3)<br class="">+ {<br class="">+ printf("%s <from> <to>\n", argv[0]);<br class="">+ return -1;<br class="">+ }<br class="">+ else if (argc == 3)<br class="">+ {<br class="">+ from = atoi(argv[1]);<br class="">+ to = atoi(argv[2]);<br class="">+ }<br class="">+<br class="">+ diff = to - from;<br class="">+ if (diff <= 0)<br class="">+ {<br class="">+ printf("Bad from/to\n");<br class="">+ return -1;<br class="">+ }<br class="">+<br class="">+ f = fopen("/dev/urandom", "r");<br class="">+ if (!f)<br class="">+ {<br class="">+ printf("Can't open /dev/urandom\n");<br class="">+ return -1;<br class="">+ }<br class="">+<br class="">+ if (1U != fread(&r, sizeof(unsigned int), 1U, f))<br class="">+ {<br class="">+ printf("Can't read /dev/urandom\n");<br class="">+ return -1;<br class="">+ }<br class="">+<br class="">+ printf("%d\n", (r % (diff +1 )) + from);<br class="">+<br class="">+ return 0;<br class="">+}<br class="">-- <br class="">2.1.4<br class=""><br class="">-- <br class="">franken-dev mailing list<br class=""><a href="mailto:franken-dev@freifunk.net" class="">franken-dev@freifunk.net</a><br class="">http://lists.freifunk.net/mailman/listinfo/franken-dev-freifunk.net<br class=""></div></div></blockquote></div><br class=""></div></body></html>